Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VideoStreamEncoder] Add a WPT that reproduces a VSE crash. #25624

Merged
merged 1 commit into from Sep 21, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 18, 2020

When we are encoding the same MediaStreamTrack multiple times there is
a race that causes VideoStreamEncoder to crash. To aid debugging, this
CL adds WPT test coverage for it.

Bug: webrtc:11485
Change-Id: I0cb2b1b1528521755c18d5c6117b60fc053480dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418376
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808796}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

When we are encoding the same MediaStreamTrack multiple times there is
a race that causes VideoStreamEncoder to crash. To aid debugging, this
CL adds WPT test coverage for it.

Bug: webrtc:11485
Change-Id: I0cb2b1b1528521755c18d5c6117b60fc053480dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418376
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808796}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants