sensors: Cleanup iframe-related tests. #25626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 18, 2020
Even after r807421 those tests are presenting some occasional flakiness in the form of timeouts and, in a few cases, crashes in other parts of the stack. Clean up the code a little bit to make the code easier to follow and perhaps reduce the chance of timeouts: * send_message_to_frame() does not need to be an async function. * Use t.add_cleanup() to a few tests to make sure any iframe we add is properly removed even if an error occurs. * Remove all calls to the assert_*() functions from both the code path used by initialize_generic_sensor_tests() as well as generic_sensor_mocks.js, so that we no longer need to include testharness.js in the iframe handler page. * Make the onmessage handler in the iframe page also send a reply when errors occur. Bug: 1073865 Change-Id: Id6f682c95212d7ad9662f8aadad31c866752b0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418333 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#808497}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2418333
branch
from
cfa4c43
to
8c3edda
Compare
|
@stephenmcgruer can you force-merge this one? This is https://crbug.com/1126926 again (there's a fix in the works that should land soon). |
|
Whoa, that was fast :-) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even after r807421 those tests are presenting some occasional flakiness in
the form of timeouts and, in a few cases, crashes in other parts of the
stack.
Clean up the code a little bit to make the code easier to follow and perhaps
reduce the chance of timeouts:
properly removed even if an error occurs.
by initialize_generic_sensor_tests() as well as generic_sensor_mocks.js,
so that we no longer need to include testharness.js in the iframe handler
page.
errors occur.
Bug: 1073865
Change-Id: Id6f682c95212d7ad9662f8aadad31c866752b0af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418333
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808497}