Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] streamlit: fix build #98226

Merged
merged 1 commit into from Sep 21, 2020
Merged

[20.09] streamlit: fix build #98226

merged 1 commit into from Sep 21, 2020

Conversation

jonringer
Copy link
Contributor

Motivation for this change

(cherry picked from commit 07660b2)

backport of #98062

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
streamlit: fix build
b8fb986 
(cherry picked from commit 07660b2)
@jonringer jonringer changed the title streamlit: fix build [20.09] streamlit: fix build Sep 18, 2020
@ofborg ofborg bot requested a review from yrashk September 18, 2020 17:57
@risicle
Copy link
Contributor

risicle commented Sep 18, 2020

This could do with some pythonImportsCheck love sometime, but WFM linux x86_64 & macos 10.14.

@jonringer
Copy link
Contributor Author

This could do with some pythonImportsCheck love sometime, but WFM linux x86_64 & macos 10.14.

That's something the "maintainer" should do, I was just want things to be green... lol

@jonringer jonringer merged commit 775b368 into NixOS:release-20.09 Sep 21, 2020
@jonringer jonringer deleted the backport-streamlit branch September 21, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrashk yrashk Awaiting requested review from yrashk

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @risicle