Origin isolation: make document.domain a no-op #25635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 18, 2020
Cross-origin access *via* document.domain is automatically prohibited by the rest of the Chromium infrastructure. However, the other effects of document.domain need to be explicitly no-op'ed. Bug: 1042415 Change-Id: I1957c924f31c985d988988c06368323aa508a19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419144 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#809817}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2419144
branch
from
2ed97c3
to
cb0021a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-origin access via document.domain is automatically prohibited
by the rest of the Chromium infrastructure. However, the other effects
of document.domain need to be explicitly no-op'ed.
Bug: 1042415
Change-Id: I1957c924f31c985d988988c06368323aa508a19c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419144
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809817}