tizonia-openmax-il: init at 0.22.0 #98217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wucke13
force-pushed
the
tizonia
branch
2 times, most recently
from
570c595
to
87c9e89
Compare
SuperSandro2000
requested changes
Feb 9, 2021
| python3 sqlite.dev taglib | ||
| ]; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
stdenv.lib got recently deprecated.
There was a problem hiding this comment.
ofborg does not allow any additions of stdenv.lib anymore.
| hardeningDisable = [ "format" ]; | ||
| enableParallelBuilding = true; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
| directories, Plex servers and Chromecast devices. | ||
| ''; | ||
| homepage = "https://tizonia.org/"; | ||
| license = licenses.lgpl3; |
There was a problem hiding this comment.
I don't see the "or later" clause in this: https://docs.tizonia.org/overview/COPYING.LESSER.html
| destinations. It is modeled after the Log for Java library . | ||
| ''; | ||
| homepage = "http://log4c.sourceforge.net/"; | ||
| license = licenses.lgpl21; |
There was a problem hiding this comment.
Good catch, it is lgpl2Plus (https://sourceforge.net/p/log4c/log4c/ci/master/tree/COPYING)
SuperSandro2000
requested changes
Feb 9, 2021
Comment on lines
+20
to
+21
| export BOOST_INCLUDEDIR="${stdenv.lib.getDev boost}/include"; | ||
| export BOOST_LIBRARYDIR="${stdenv.lib.getLib boost}/lib"; |
There was a problem hiding this comment.
Suggested change
| export BOOST_INCLUDEDIR="${stdenv.lib.getDev boost}/include"; | |
| export BOOST_LIBRARYDIR="${stdenv.lib.getLib boost}/lib"; | |
| export BOOST_INCLUDEDIR="${lib.getDev boost}/include"; | |
| export BOOST_LIBRARYDIR="${lib.getLib boost}/lib"; |
| python3 sqlite.dev taglib | ||
| ]; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
ofborg does not allow any additions of stdenv.lib anymore.
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)