Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.word2vec: fix build and tests #98223

Merged
merged 1 commit into from Sep 22, 2020
Merged

[20.09] python3Packages.word2vec: fix build and tests #98223

merged 1 commit into from Sep 22, 2020

Conversation

wkral
Copy link
Contributor

@wkral wkral commented Sep 18, 2020

(cherry picked from commit 6a4e785)

Motivation for this change

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wkral
Copy link
Contributor Author

wkral commented Sep 18, 2020

Result of nixpkgs-review pr 98223 1

2 packages built:
  • python37Packages.word2vec
  • python38Packages.word2vec

jonringer
jonringer approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98223 1

2 packages built:
  • python37Packages.word2vec
  • python38Packages.word2vec

@wkral
Copy link
Contributor Author

wkral commented Sep 22, 2020

@jonringer noticed that this hasn't been merged, guessing just overlooked amongst the many PRs. If it does need work please let me know.

@jonringer jonringer merged commit 4eec4a7 into NixOS:release-20.09 Sep 22, 2020
@jonringer
Copy link
Contributor

i do a rebase, github probably had a merge right before this, and it failed to apply

@wkral wkral deleted the backport-py-word2vec branch September 22, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkral @jonringer