Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ungoogled-chromium: 84.0.4147.89-1 -> 85.0.4183.102-1 #98231

Merged
merged 1 commit into from Sep 19, 2020
Merged

ungoogled-chromium: 84.0.4147.89-1 -> 85.0.4183.102-1 #98231

merged 1 commit into from Sep 19, 2020

Conversation

squalus
Copy link
Member

@squalus squalus commented Sep 18, 2020

Motivation for this change

This updates ungoogled-chromium. This change was created by manually copying the regular chromium expressions and applying a small diff to support the ungoogled patchset.

Performed a cursory test and everything looks good.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @danielfullmer

ungoogled-chromium: 84.0.4147.89-1 -> 85.0.4183.102-1
8344cba 
based on chromium master@05f5001c
@danielfullmer
Copy link
Contributor

Built and briefly tested working on twitch/youtube/etc.

@squalus
Copy link
Member Author

squalus commented Sep 19, 2020

@primeos

@primeos primeos merged commit 54a0a40 into NixOS:master Sep 19, 2020
@primeos
Copy link
Member

primeos commented Sep 19, 2020

Thanks :)
Cherry-picked to 20.09 in bfb429d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@squalus @danielfullmer @primeos