Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bluej: init at 4.2.2 #98204

Merged
merged 2 commits into from Sep 21, 2020
Merged

bluej: init at 4.2.2 #98204

merged 2 commits into from Sep 21, 2020

Conversation

chvp
Copy link
Member

@chvp chvp commented Sep 18, 2020 •
edited

Motivation for this change

I need it for a university course I'm a teaching assistent for. Based on #59718 (and the review comments left there).

Things done

Running the program works (only with the jetbrains JDK, sadly, openjdk hangs on the boot splash). In the program, creating a new project, compiling a class, creating a new object and calling a method on that object works.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@chvp chvp force-pushed the pr/init-bluej branch 2 times, most recently from 83494ea to fbf0483 Compare September 18, 2020 10:59
@chvp chvp force-pushed the pr/init-bluej branch 4 times, most recently from 9ddb904 to 459a72c Compare September 20, 2020 10:10
doronbehar
doronbehar requested changes Sep 20, 2020
View reviewed changes
pkgs/applications/editors/bluej/default.nix Show resolved Hide resolved
pkgs/applications/editors/bluej/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/bluej/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/bluej/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/bluej/default.nix Show resolved Hide resolved
doronbehar
doronbehar approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine with nixpkgs-review and GUI seems functional.

@doronbehar doronbehar merged commit 20bd6dd into NixOS:master Sep 21, 2020
@chvp chvp deleted the pr/init-bluej branch September 21, 2020 08:11
@chvp chvp mentioned this pull request Sep 27, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chvp @doronbehar