Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.19.2 -> 1.19.3 #98218

Merged
merged 1 commit into from Sep 20, 2020
Merged

matrix-synapse: 1.19.2 -> 1.19.3 #98218

merged 1 commit into from Sep 20, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 18, 2020

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v1.19.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 18, 2020
@Ma27 Ma27 added this to the 20.09 milestone Sep 18, 2020
@Ma27
Copy link
Member Author

Ma27 commented Sep 18, 2020

@GrahamcOfBorg test matrix-synapse

@ofborg ofborg bot requested a review from pacien September 18, 2020 15:31
mguentner
mguentner approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@mguentner mguentner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cherry-picked against 20.03 and tested in production ✔️

@Ma27 Ma27 merged commit 783bf0a into NixOS:master Sep 20, 2020
@Ma27 Ma27 deleted the bump-matrix-synapse branch September 20, 2020 17:36
@Ma27
Copy link
Member Author

Ma27 commented Sep 20, 2020

Ported to 20.09 as 3114b45, to 20.03 as 6b11dbe.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog Ekleog Ekleog approved these changes

@mguentner mguentner mguentner approved these changes

@ajs124 ajs124 ajs124 approved these changes

@Ralith Ralith Awaiting requested review from Ralith

@fadenb fadenb Awaiting requested review from fadenb

@pacien pacien Awaiting requested review from pacien

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @Ekleog @mguentner @ajs124