Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COOP] access reporting: openeeURL, openerURL, otherDocumentURL #25629

Merged
merged 1 commit into from Sep 30, 2020
Merged

[COOP] access reporting: openeeURL, openerURL, otherDocumentURL #25629

merged 1 commit into from Sep 30, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 18, 2020 •
edited

The coop-reporting-explainer defined several URLs that might be
reported:

  • openeeURL
  • openerURL
  • otherDocumentURL
  • referrerURL
  • initialPopupURL

This adds the first 3.

Bug: 1090273
Change-Id: Ibd9710139e0065bd36fe6e798b50521f6d24baf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398619
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812144}

wpt-pr-bot
wpt-pr-bot approved these changes Sep 18, 2020
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2398619 branch 2 times, most recently from 8351082 to 889e2f1 Compare September 25, 2020 19:31
@ArthurSonzogni @chromium-wpt-export-bot
[COOP] access reporting: openeeURL, openerURL, otherDocumentURL
6849852 
The [coop-reporting-explainer] defined several URLs that might be
reported:
- openeeURL
- openerURL
- otherDocumentURL
- referrerURL
- initialPopupURL

This adds the first 3.

[coop-reporting-explainer]:
https://github.com/camillelamy/explainers/blob/master/coop_reporting.md

Bug: 1090273
Change-Id: Ibd9710139e0065bd36fe6e798b50521f6d24baf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398619
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812144}
@ArthurSonzogni
Copy link
Member

ArthurSonzogni commented Sep 30, 2020 •
edited

For WPT sheriff:
This patch modified existing tests. They used to trigger "wpt-chrome-dev-stability" and they continue to do so.
This problem is investigated here: https://bugs.chromium.org/p/chromium/issues/detail?id=1098413#c17

This patch is unrelated to this (and the next 2 ones I am going to land soon). So you can merge if only "wpt-chrome-dev-stability" is failing.

@KyleJu
Copy link
Contributor

KyleJu commented Sep 30, 2020

For WPT sheriff:
This patch modified existing tests. They used to trigger "wpt-chrome-dev-stability" and they continue to do so.
This problem is investigated here: https://bugs.chromium.org/p/chromium/issues/detail?id=1098413#c17

This patch is unrelated to this (and the next 2 ones I am going to land soon). So you can merge if only "wpt-chrome-dev-stability" is failing.

@ArthurSonzogni Thanks for letting me know! @Hexcles could you admin merge this? The timeout in Firefox is expected.

@Hexcles Hexcles merged commit 360ac70 into master Sep 30, 2020
@Hexcles Hexcles deleted the chromium-export-cl-2398619 branch September 30, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
chromium-export html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chromium-wpt-export-bot @ArthurSonzogni @KyleJu @wpt-pr-bot @Hexcles @moz-wptsync-bot