Reland: "[layout] Ensure fragment tree consistency." #25631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 18, 2020
Original change description: > This patch ensures that we always have a "consistent" fragment-tree (or > rather a portion of a fragment-tree if we have legacy nodes). > Previously it was possible for a fragment-tree to become inconsistent > whenever we performed layout from a subtree root. Now when we layout > from a node like this, we rebuild the "spine" of the tree. > After this change we'll be able to remove most "PostLayout" calls, > except where they are used for building this "consistent" tree. The first change had two issues. 1) Cloning a part of the fragment tree which had its layout-objects removed from the tree. The fix for this specific issue is to stop re-building the spine of the tree when we encounter an object which needs layout. 2) AbstractInlineTextBox holding a stale pointer to an NGFragmentItem. The fix for this specific issue is to call: DetachAbstractInlineTextBoxesIfNeeded on any NGFragmentItem(s) which have an associated LayoutText. Bug: 1066616 Change-Id: Iade8d4c2e7ae9129863d3b295271da944ffec81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418978 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#808453}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2418978
branch
from
b583ee7
to
f4c9280
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original change description:
The first change had two issues.
removed from the tree. The fix for this specific issue is to stop
re-building the spine of the tree when we encounter an object which
needs layout.
The fix for this specific issue is to call:
DetachAbstractInlineTextBoxesIfNeeded on any NGFragmentItem(s) which
have an associated LayoutText.
Bug: 1066616
Change-Id: Iade8d4c2e7ae9129863d3b295271da944ffec81e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418978
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808453}