Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to ROCm 3.8.0 #98230

Merged
merged 9 commits into from Sep 23, 2020
Merged

Update to ROCm 3.8.0 #98230

merged 9 commits into from Sep 23, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Sep 18, 2020 •
edited

Motivation for this change

Update to ROCm 3.8.0.

cc: @acowley @Flakebi

It would be nice if someone could test if this works, I had to replace my RX380.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
rocm-runtime: 3.7.0 -> 3.8.0
c1c5e46 
The tag refers to the same commit as 3.7.0, so the hash did not
change.
@danieldk
rocm-comgr: 3.7.0 -> 3.8.0
f038c7b
@danieldk
rocm-cmake: 3.7.0 -> 3.8.0
44b5370 
The tag refers to the same commit as 3.7.0, so the hash did not
change.
@danieldk
rocclr: 3.7.0 -> 3.8.0
b535b62
@danieldk
rocm-opencl-runtime: 3.7.0 -> 3.8.0
14963fd
@danieldk
rocm-smi: 3.7.0 -> 3.8.0
57bf669 
The tag refers to the same commit as 3.7.0, so the hash did not
change.
@danieldk danieldk marked this pull request as ready for review September 19, 2020 06:17
@danieldk danieldk removed the request for review from matthewbauer September 19, 2020 06:18
@Flakebi
Copy link
Member

Flakebi commented Sep 23, 2020

Thanks, seems to build and work fine. clinfo works, other OpenCL samples hang my (unsupported) GPU, so same as 3.7 for me.

$ nixpkgs-review pr 98230
9 packages built:
rocclr rocm-cmake rocm-comgr rocm-device-libs rocm-opencl-icd rocm-opencl-runtime rocm-runtime rocm-smi rocm-thunk

@danieldk
Copy link
Contributor Author

Thanks for testing. Hopefully there will soon be progress on Navi.

@danieldk danieldk merged commit 66d0662 into NixOS:master Sep 23, 2020
@danieldk danieldk deleted the rocm-3.8.0 branch September 23, 2020 17:25
@acowley
Copy link
Contributor

acowley commented Sep 23, 2020

Sorry for the delay, I started building 3.8 things this morning, but it's not done yet. The changes all look innocuous, but I'll report back in any case.

@acowley
Copy link
Contributor

acowley commented Sep 23, 2020

OpenCL and HIP are working for me with these updates, thank you @danieldk!

@danieldk
Copy link
Contributor Author

Awesome, thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @Flakebi @acowley