Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dwarf-fortress: update themes.json #98229

Merged
merged 1 commit into from Sep 21, 2020
Merged

dwarf-fortress: update themes.json #98229

merged 1 commit into from Sep 21, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Sep 18, 2020

Motivation for this change

I wanted the vettlingr theme.

Tested build with nix-build -I nixpkgs=/home/bbigras/nixpkgs -E 'with (import <nixpkgs>{}); pkgs.dwarf-fortress-packages.dwarf-fortress-full.override { theme = "vettlingr"; enableIntro = false; enableFPS = true; }'.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbigras
Copy link
Contributor Author

bbigras commented Sep 18, 2020

also tested with nix-review:

2 packages added:
dwarf-fortress-packages.themes.meph (init at 47.04_v5.5.0_V1.1.2) dwarf-fortress-packages.themes.vettlingr (init at 1.4a)

12 packages updated:
dwarf-fortress-packages.themes.afro-graphics (47.02 → 47.04) dwarf-fortress-full dwarf-fortress-packages.themes.gemset (47.02 → 47.04) dwarf-fortress-packages.themes.ironhand (47.02 → 47.04) dwarf-fortress-packages.themes.jolly-bastion (47.02 → 47.04) dwarf-fortress-packages.themes.mayday (47.01 → 47.04a) dwarf-fortress-packages.themes.obsidian (47.02 → 47.04a) dwarf-fortress-packages.phoebus-theme (47.02a → 47.04a) dwarf-fortress-packages.themes.rally-ho (47.02 → 47.04) dwarf-fortress-packages.themes.spacefox (47.02 → 47.04) dwarf-fortress-packages.themes.taffer (47.01b → 47.04) dwarf-fortress-packages.themes.wanderlust (47.02 → 47.04)

14 packages built:
dwarf-fortress-packages.dwarf-fortress-full dwarf-fortress-packages.phoebus-theme dwarf-fortress-packages.themes.afro-graphics dwarf-fortress-packages.themes.gemset dwarf-fortress-packages.themes.ironhand dwarf-fortress-packages.themes.jolly-bastion dwarf-fortress-packages.themes.mayday dwarf-fortress-packages.themes.meph dwarf-fortress-packages.themes.obsidian dwarf-fortress-packages.themes.rally-ho dwarf-fortress-packages.themes.spacefox dwarf-fortress-packages.themes.taffer dwarf-fortress-packages.themes.vettlingr dwarf-fortress-packages.themes.wanderlust

@bbigras
Copy link
Contributor Author

bbigras commented Sep 19, 2020

@matthewbauer @shazow

shazow
shazow approved these changes Sep 19, 2020
View reviewed changes
Copy link
Contributor

@shazow shazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/234

@marsam marsam merged commit 7c7ee58 into NixOS:master Sep 21, 2020
@bbigras bbigras deleted the df branch September 21, 2020 01:12
@bbigras
Copy link
Contributor Author

bbigras commented Sep 21, 2020

Thanks everybody!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shazow shazow shazow approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbigras @nixos-discourse @shazow @marsam