Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kdeapps #98212

Closed
wants to merge 305 commits into from
Closed

Add kdeapps #98212

wants to merge 305 commits into from

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Sep 18, 2020 •
edited

Motivation for this change

Continuing the process to make all applications in applications/kde/srcs.nix, I used the same technique as the previous PR:

  • one commit per lib/app
  • export user facing apps in top-level/all-packages.nix

A few notes:

  • I had to modify the accounts-qt package as the structure of the out was fooling cmake
  • I added signond as it contains the dbus information required for kaccounts-integration package, but didn't take care to enable a service for it
  • Dev apps (kdesdk, etc) are only in kdeApplications namespace

A few kde apps are still not packaged, three I didn't succeed yet (cervisia, signon-kwallet-extension and artikulate), kopete as it is obsolete upstream and all the telepathy stack

Maybe we should push this to staging ?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
Copy link
Contributor

@freezeboy your work is valuable, but I'm afraid it may not worth the maintainence effort to put all of these packagegs in our collection. Do you think you can add here only those that you personally would like to use?

@freezeboy
Copy link
Contributor Author

What do you mean in "maintainance effort"? basically all the sources are updates in bulk with the srcs.nix file for kde, I just thought it was sad not to provide packages when it is just a matter of listing the deps of each app.

@doronbehar
Copy link
Contributor

Listing the deps and maintaining them is the maintenance. Personally I do tend to think the more is the better, but @ttuegel 's approval might be needed for this. Let's hope he'll find time to review this.

@doronbehar
Copy link
Contributor

20.08.2 is out in the meantime..

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/272

@doronbehar
Copy link
Contributor

@freezeboy there are merge conflicts, and I'd post this PR in the "ready for review" thread.

@doronbehar
Copy link
Contributor

It should be a rebase instead of a merge master into your branch. Also the commit messages should be init at 20.08.2. You don't have to separate all of them into separate commits IMO.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/368

@stigtsp
[nix-update-cpan] perlPackages.GitAutofixup: 0.002007 -> 0.003001
8de23f1
@stigtsp
[nix-update-cpan] perlPackages.GlibObjectIntrospection: 0.048 -> 0.049
736394b
@stigtsp
[nix-update-cpan] perlPackages.Gnome2Canvas: 1.002 -> 1.004
d6bde2e
@stigtsp
[nix-update-cpan] perlPackages.Graph: 0.9704 -> 0.9712
3b7debe
@stigtsp
[nix-update-cpan] perlPackages.HTMLTableExtract: 2.13 -> 2.15
22843df
@stigtsp
[nix-update-cpan] perlPackages.HTTPCookieJar: 0.008 -> 0.010
eec464c
@stigtsp
[nix-update-cpan] perlPackages.HTTPCookies: 6.08 -> 6.09
1c3696f
@stigtsp
[nix-update-cpan] perlPackages.HTTPDaemon: 6.01 -> 6.12
a0d34c7
@stigtsp
[nix-update-cpan] perlPackages.HTTPEntityParser: 0.24 -> 0.25
5dc16af
@stigtsp
[nix-update-cpan] perlPackages.HTTPMessage: 6.25 -> 6.26
99138c4
@stigtsp
[nix-update-cpan] perlPackages.IOAIO: 4.72 -> 4.73
3ccacfb
@stigtsp
[nix-update-cpan] perlPackages.IOHTML: 1.001 -> 1.004
2f19d93
@stigtsp
[nix-update-cpan] perlPackages.IOPager: 1.03 -> 2.10
7a5522c
kennyballou added a commit to kennyballou/nixpkgs that referenced this pull request May 21, 2021
@kennyballou @freezeboy
akonadi-calendar-tools: init 20.12.3
7a545e1 
Borrowing expressions from a stalled/stale PR: NixOS#98212.

Co-authored-by: freezeboy <freezeboy@users.noreply.github.com>
Signed-off-by: Kenny Ballou <kb@devnulllabs.io>
kennyballou added a commit to kennyballou/nixpkgs that referenced this pull request May 21, 2021
@kennyballou @freezeboy
kaccounts-providers: init 20.12.3
05e48e1 
Borrowing expressions from a stalled/stale PR: NixOS#98212.

Co-authored-by: freezeboy <freezeboy@users.noreply.github.com>
Signed-off-by: Kenny Ballou <kb@devnulllabs.io>
kennyballou added a commit to kennyballou/nixpkgs that referenced this pull request May 21, 2021
@kennyballou @freezeboy
kio-gdrive: init 20.12.3
6314748 
Borrowing expressions from a stalled/stale PR: NixOS#98212.

Co-authored-by: freezeboy <freezeboy@users.noreply.github.com>
Signed-off-by: Kenny Ballou <kb@devnulllabs.io>
peterhoeg pushed a commit that referenced this pull request May 31, 2021
@kennyballou @freezeboy @peterhoeg
akonadi-calendar-tools: init 20.12.3
7ff8b88 
Borrowing expressions from a stalled/stale PR: #98212.

Co-authored-by: freezeboy <freezeboy@users.noreply.github.com>
Signed-off-by: Kenny Ballou <kb@devnulllabs.io>
peterhoeg pushed a commit that referenced this pull request May 31, 2021
@kennyballou @freezeboy @peterhoeg
kaccounts-providers: init 20.12.3
af22c92 
Borrowing expressions from a stalled/stale PR: #98212.

Co-authored-by: freezeboy <freezeboy@users.noreply.github.com>
Signed-off-by: Kenny Ballou <kb@devnulllabs.io>
peterhoeg pushed a commit that referenced this pull request May 31, 2021
@kennyballou @freezeboy @peterhoeg
kio-gdrive: init 20.12.3
28c3c08 
Borrowing expressions from a stalled/stale PR: #98212.

Co-authored-by: freezeboy <freezeboy@users.noreply.github.com>
Signed-off-by: Kenny Ballou <kb@devnulllabs.io>
@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@SuperSandro2000
Copy link
Member

Closing due to inactivity from author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@adisbladis adisbladis Awaiting requested review from adisbladis

@alyssais alyssais Awaiting requested review from alyssais

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer jonringer is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@RaghavSood RaghavSood Awaiting requested review from RaghavSood RaghavSood is a code owner

@stigtsp stigtsp Awaiting requested review from stigtsp stigtsp is a code owner

@teto teto Awaiting requested review from teto teto is a code owner

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: emacs 6.topic: nixos 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: stdenv Standard environment 6.topic: xfce The Xfce Desktop Environment 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet