Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.fluent-logger: relax version for msgpack #98211

Merged
merged 1 commit into from Sep 18, 2020
Merged

python3Packages.fluent-logger: relax version for msgpack #98211

merged 1 commit into from Sep 18, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Sep 18, 2020 •
edited

Also add imports tests as we can't do more using the pip release

Motivation for this change

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
python3Packages.fluent-logger: relax version for msgpack
8ccad60 
Also add imports tests as we can't do more using the pip release
jonringer
jonringer approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98211 1

3 packages built:
  • python27Packages.fluent-logger
  • python37Packages.fluent-logger
  • python38Packages.fluent-logger

@jonringer jonringer merged commit e3c1b87 into NixOS:master Sep 18, 2020
@freezeboy freezeboy deleted the fix-fluent-logger branch September 23, 2020 10:03
@freezeboy freezeboy mentioned this pull request Sep 23, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @jonringer