Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ndjson: init at 0.3.1 #101355

Closed
wants to merge 2 commits into from
Closed

pythonPackages.ndjson: init at 0.3.1 #101355

wants to merge 2 commits into from

Conversation

nbke
Copy link
Contributor

@nbke nbke commented Oct 22, 2020

Motivation for this change

labelbox 2.4.6 depends on ndjson

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 22, 2020 •
edited

Why is there a 0.3.1 on pypi when there is only 0.3.0 on GitHub?

I created an issue upstream rhgrant10/ndjson#7

@nbke
Copy link
Contributor Author

nbke commented Oct 22, 2020

Version 0.3.1 includes a typo fix (PR rhgrant10/ndjson#3). No code was changed between v0.3.0 and v0.3.1.
I can switch to v0.3.0 if preferred.

@SuperSandro2000
Copy link
Member

I can switch to v0.3.0 if preferred.

I am not sure where I read it but I think fetching from GitHub is preferred if available. If you would switch to GitHub tags it would be clearer and we would update when 0.3.1 is tagged.

Right now it kinda looks fishy if 0.3.1 is on pypi but not GitHub but I am not sure how this is handled. Just my opinion.

@nbke
Copy link
Contributor Author

nbke commented Oct 29, 2020

The tests are included in the package from PyPi.
@FRidh @jonringer Do you prefer fetchPypi or fetchFromGitHub?

@SuperSandro2000
Copy link
Member

The tests are included in the package from PyPi.
Do you prefer fetchPypi or fetchFromGitHub?

Then you can use fetchPypi.

@SuperSandro2000
Copy link
Member

This package is already in master. If you want to add changes please modify this PR or open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nbke @SuperSandro2000