Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

srt: 1.4.1 -> 1.4.2 #101308

Merged
merged 1 commit into from Oct 22, 2020
Merged

srt: 1.4.1 -> 1.4.2 #101308

merged 1 commit into from Oct 22, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Oct 22, 2020

Motivation for this change

https://github.com/Haivision/srt/releases/tag/v1.4.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC @lukegb

@nh2 nh2 self-assigned this Oct 22, 2020
@nh2
Copy link
Contributor Author

nh2 commented Oct 22, 2020

@GrahamcOfBorg build gst_all_1.gst-plugins-bad

lukegb
lukegb approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@lukegb lukegb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Oct 22, 2020
jtojnar
jtojnar approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not see anything suspicious in changelog.

@nh2 nh2 merged commit 8f8e6dc into NixOS:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb approved these changes

@jtojnar jtojnar jtojnar approved these changes

Assignees

@nh2 nh2

Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @lukegb @jtojnar