Reviewed points

• package path fits guidelines
• package name fits guidelines
• package version fits guidelines
• package build on ARCHITECTURE
• executables tested on ARCHITECTURE
• meta.description is set and fits guidelines
• meta.license fits upstream license
• meta.platforms is set
• meta.maintainers is set
• build time only dependencies are declared in nativeBuildInputs
• source is fetched using the appropriate function
• phases are respected
• patches that are remotely available are fetched with fetchpatch

Possible improvements

Comments

I do not have the relevant hardware, and realized anything I'm going to test this on is running a newer kernel. This otherwise looks ok to me.

Perhaps if there is any way to know which kernel version this stops being compatible with? Is it possible to prevent this in nix from being built with those kernels?

For instance: is there a way to limit it to the known-buildable kernels?

2 packages marked as broken and skipped:
linuxPackages_hardkernel_4_14.rtl8822ce linuxPackages_hardkernel_latest.rtl8822ce

8 packages failed to build:
linuxPackages_5_8.rtl8822ce linuxPackages_5_9.rtl8822ce linuxPackages_latest-libre.rtl8822ce linuxPackages_latest_hardened.rtl8822ce linuxPackages_latest_xen_dom0.rtl8822ce linuxPackages_latest_xen_dom0_hardened.rtl8822ce linuxPackages_testing_bcachefs.rtl8822ce linuxPackages_zen.rtl8822ce

9 packages built:
linuxPackages-libre.rtl8822ce linuxPackages.rtl8822ce linuxPackages_4_14.rtl8822ce linuxPackages_4_19.rtl8822ce linuxPackages_4_4.rtl8822ce linuxPackages_4_9.rtl8822ce linuxPackages_hardened.rtl8822ce linuxPackages_xen_dom0.rtl8822ce linuxPackages_xen_dom0_hardened.rtl8822ce

I am not quite sure what is known but I know that zen kernel already have it. Maybe we can just limit it to those that already failed in CI?

Perhaps if there is any way to know which kernel version this stops being compatible with? Is it possible to prevent this in nix from being built with those kernels?

Definitely it's possible - you just need to assert before mkDerivation that the version is old enough and throw a proper message otherwise. @pickfire please use lib.asserts.assertMsg (https://nixos.org/manual/nixpkgs/stable/#sec-functions-library) and lib.strings.versionOlder

I am not using nixos anymore and for this one just use one of those kernels to fix it. Closing it.