New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xmlsec: fix build on macOS #101319
Merged
Merged
xmlsec: fix build on macOS #101319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmlsec detects the Darwin platform and uses the -D flag with base64, but nix uses GNU base64 which requires -d. This patch removes the platform test and always uses the -d flag.
ofborg
bot
added
6.topic: darwin
Running or building packages on Darwin
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
Oct 22, 2020
SuperSandro2000
approved these changes
Oct 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds on darwin.
Run on darwin: Result of 2 packages marked as broken and skipped:
1 package failed to build:
5 packages built:
|
I think we should set pysaml2 to only build darwin on python38.
|
marsam
reviewed
Oct 31, 2020
Co-authored-by: Mario Rodas <marsam@users.noreply.github.com>
Good idea, I've updated the patch with your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: darwin
Running or building packages on Darwin
10.rebuild-darwin: 1-10
10.rebuild-linux: 0
12. first-time contribution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xmlsec detects the Darwin platform and uses the -D flag with base64, but nix uses GNU base64 which requires -d.
This patch removes the platform test and always uses the -d flag.
Motivation for this change
The recent update of xmlsec to version 1.2.30 broke xmlsec on macOS. See the bug: #101276
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)