Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpd: fix build without documentation feature #101352

Merged
merged 1 commit into from Oct 22, 2020
Merged

mpd: fix build without documentation feature #101352

merged 1 commit into from Oct 22, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Oct 22, 2020

Motivation for this change

The mpd-small build currently fails with a

builder for '/nix/store/r…k-mpd-0.22.1.drv' failed to produce output path '/nix/store/i…b-mpd-0.22.1-man'

error, because the man pages are only generated when the documentation feature is activated (sphinx is found). Otherwise no files are installed in $man and the output is not created.

https://hydra.nixos.org/build/128742309

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@B4dM4n
mpd: fix build without documentation feature
40c9b28 
The man pages are only generated when the `documentation` feature is
activated (sphinx is found). Otherwise no files are installed in `$man`
and the output is not created.
@ofborg ofborg bot requested review from tobim, ehmry, astsmtl and fpletz October 22, 2020 11:16
tobim
tobim approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the issue is real and the fix works.

@doronbehar doronbehar merged commit 2b39a8e into NixOS:master Oct 22, 2020
@B4dM4n B4dM4n deleted the mpd-small-fix branch October 25, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

@ehmry ehmry Awaiting requested review from ehmry

@astsmtl astsmtl Awaiting requested review from astsmtl

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@B4dM4n @tobim @doronbehar