Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] retroarch/cores: unmark broken #102145

Merged
merged 1 commit into from Oct 30, 2020
Merged

[20.09] retroarch/cores: unmark broken #102145

merged 1 commit into from Oct 30, 2020

Conversation

Omoroca13
Copy link
Contributor

Motivation for this change

in #101736 nearly all retroarch cores got marked as broken.
As far as I can tell on Hydra only mame2016 failed to build. (I am struggling too read it though so I might be missing something)

I tried my Cores with nixpkgs.config.allowBroken = true; and they seem to be working.

This pull request reverts the marking of all cores as broken and marks mame2016 as broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edwtjo, hrdinka and MP2E October 30, 2020 10:34
@SuperSandro2000
Copy link
Member

I am guessing that the script is not smart enough to properly mark this package.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102145 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • libretro.mame2016

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102145 run on x86_64-linux 1

1 package marked as broken and skipped:
  • libretro.mame2016

@veprbl veprbl merged commit e06cdf5 into NixOS:release-20.09 Oct 30, 2020
@AluisioASG AluisioASG mentioned this pull request Oct 30, 2020
Merged
10 tasks
@veprbl veprbl mentioned this pull request Oct 31, 2020
Closed
@Omoroca13 Omoroca13 deleted the libretro-cores branch November 13, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo

@hrdinka hrdinka Awaiting requested review from hrdinka

@MP2E MP2E Awaiting requested review from MP2E

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Omoroca13 @SuperSandro2000 @veprbl