New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add step-ca 0.15.5 #102131
Add step-ca 0.15.5 #102131
Conversation
Removed unnecessary buildGoPackage.
Update description
@@ -0,0 +1,42 @@ | |||
{ lib, buildGoModule, buildGoPackage, fetchFromGitHub }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ lib, buildGoModule, buildGoPackage, fetchFromGitHub }: | |
{ lib, buildGoModule, fetchFromGitHub }: |
let | ||
sha256 = "01y4wi6j1frfpd6ndwrxw4sr9rwhj8m96mvp76rnszzwgvlydgd4"; | ||
vendorSha256 = "1is4rvga3anmzqqd1bmdw3014lxrvnm19jrfpyvmdqh7pc7cm4i5"; | ||
version = "0.15.5"; | ||
in | ||
buildGoModule { | ||
inherit vendorSha256; | ||
inherit version; | ||
pname = "step-ca"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let | |
sha256 = "01y4wi6j1frfpd6ndwrxw4sr9rwhj8m96mvp76rnszzwgvlydgd4"; | |
vendorSha256 = "1is4rvga3anmzqqd1bmdw3014lxrvnm19jrfpyvmdqh7pc7cm4i5"; | |
version = "0.15.5"; | |
in | |
buildGoModule { | |
inherit vendorSha256; | |
inherit version; | |
pname = "step-ca"; | |
buildGoModule rec { | |
version = "0.15.5"; | |
pname = "step-ca"; |
pname = "step-ca"; | ||
|
||
src = fetchFromGitHub { | ||
inherit sha256; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inherit sha256; | |
sha256 = "1zr78p2jxhajqv59kwqqq02njzr4s20ddixyh2ki95p6afniw7wp"; |
rev = "v${version}"; | ||
}; | ||
|
||
goPackagePath = "github.com/smallstep/certificates"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goPackagePath = "github.com/smallstep/certificates"; | |
goPackagePath = "github.com/smallstep/certificates"; | |
vendorSha256 = "1is4rvga3anmzqqd1bmdw3014lxrvnm19jrfpyvmdqh7pc7cm4i5"; |
|
||
buildPhase = '' | ||
runHook preBuild | ||
CGO_ENABLED=0 go build -v -o bin/step-ca -ldflags='-w -X "main.Version=${version}" -X "main.BuildTime=1969-12-31 23:59 UTC"' github.com/smallstep/certificates/cmd/step-ca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CGO_ENABLED=0 go build -v -o bin/step-ca -ldflags='-w -X "main.Version=${version}" -X "main.BuildTime=1969-12-31 23:59 UTC"' github.com/smallstep/certificates/cmd/step-ca | |
CGO_ENABLED=0 go build -v -o bin/step-ca -ldflags='-w -X "main.Version=${version}" -X "main.BuildTime=1969-12-31 23:59 UTC"' github.com/smallstep/certificates/cmd/step-ca | |
runHook postBuild |
Why did you not update the 0.13.X version? |
I haven't read step-ca change log. |
Is this still being worked on? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits and change PR and commit title to step-ca: init at 0.15.5
@dsx I don't understand but isn't this version already in master? https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/security/step-ca/default.nix |
Indeed, looks like it's covered by #93711. |
Good catch! Closing as duplicate. Maybe we want to add an alias for this? |
@SuperSandro2000 There already exist |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)