fetchzip: remove write permissions for unpacked files #102114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #38649
Some zip files contain 4.4.15 external file attributes that may set the write bit of unpacked files. This change ensures that all files fetched & unpacked with
fetchzip
will have their write bits cleared as final step. This change should not affect the hash of any outputs built withfetchzip
.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
I manually rebuilt all projects that used
extraPostFetch
as a workaround, and they all still resolve to the their original hashes. However, ipmicfg isn't exposed through an attribute, and when I tried to build it, it failed with:./result/bin/
)nix path-info -S
before and after)