Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.lacaml: 11.0.6 → 11.0.8 #102132

Merged
merged 1 commit into from Nov 1, 2020
Merged

ocamlPackages.lacaml: 11.0.6 → 11.0.8 #102132

merged 1 commit into from Nov 1, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 30, 2020

Motivation for this change

Use Dune 2.

cc @rixed maintainer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rixed
Copy link
Contributor

rixed commented Oct 30, 2020

Note that I'm not using nixos these days and therefore the maintainer field should probably be changed as well.

@vbgl
Copy link
Contributor Author

vbgl commented Oct 30, 2020

Thanks. I’ve thus changed the maintainers field.

@ehmry ehmry merged commit 546ef7a into NixOS:master Nov 1, 2020
@vbgl vbgl deleted the ocaml-lacaml-11.0.8 branch November 1, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @rixed @ehmry