Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/throttled: disable kernel msr warning #102106

Merged
merged 1 commit into from Dec 29, 2020
Merged

nixos/throttled: disable kernel msr warning #102106

merged 1 commit into from Dec 29, 2020

Conversation

tadfisher
Copy link
Contributor

Motivation for this change

Kernel 5.9 has begun printing warnings whenever userspace writes to CPU MSR registers, which throttled does to control CPU voltage. See erpalma/throttled#215

The kernel devs are working on a solution for this issue, which may involve a new API for controlling CPU voltage. See https://lore.kernel.org/lkml/20200907094843.1949-1-Jason@zx2c4.com/T/#u

In the meantime, to avoid spamming the kernel log buffer, enable msr.allow_writes for kernels 5.9 and newer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bkchr
bkchr approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

@Patryk27
Copy link
Member

Works for me too 👍

@flokli
Copy link
Contributor

flokli commented Dec 29, 2020

Too bad the LKML discussion has gotten somewhat silent. Setting this in the throttled module is probably fine.

@flokli flokli merged commit 316862f into NixOS:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tadfisher @Patryk27 @flokli @bkchr