Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plover.dev: fix Qt version pinning #102127

Merged
merged 1 commit into from Oct 30, 2020
Merged

plover.dev: fix Qt version pinning #102127

merged 1 commit into from Oct 30, 2020

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Oct 30, 2020 •
edited

Motivation for this change

This should likely be backported to 20.09.

Issue report: #65399 (comment) and #98069 (cc @Xe, @dnaq)

Similar issues in #98067.

Plover seems to work fine with Qt > 5.14 so this is an easy way to fix
the problem (as opposed to keeping the pinning and making it work with
PyQt).

Closes #98069.

@FRidh I'm not sure I completely understood the libsForQt + Python problem, could you double check that this is not a stupid way of fixing the problem? Thanks.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
plover.dev: fix Qt version pinning
40c9431 
Issue report: NixOS#65399 (comment)

Similar issues in NixOS#98067.

Plover seems to work fine with Qt > 5.14 so this is an easy way to fix
the problem (as opposed to keeping the pinning and making it work with
PyQt).
@delroth
Copy link
Contributor Author

delroth commented Oct 30, 2020

@ofborg build plover.dev

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 30, 2020 •
edited

Result of nixpkgs-review pr 102127 run on x86_64-darwin 1

1 package failed to build:
  • plover.dev
Running configuration tests...
Checking for valid makespec...
+ cd /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/config.tests/verifyspec && /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/bin/qmake "CONFIG -= qt debug_and_release app_bundle lib_bundle" "CONFIG += shared warn_off console single_arch" 'QMAKE_LIBDIR += /nix/store/x2r6z8m6h8aaq4g0sgkw8amfscdk1f6q-icu4c-67.1/lib /nix/store/bkbw8vp4g3fnkcsrw9ayfazk096rjd7n-zlib-1.2.11/lib /nix/store/4lcgzmjmipg8s4cg5qflhs5afnsaah19-libjpeg-turbo-2.0.5/lib /nix/store/xm0jvjxb2ga3vd5icpz0ldx57pjpzinp-harfbuzz-2.7.1/lib /nix/store/4115fabrf3hcccwa760057pqxvssmh13-openssl-1.1.1g/lib' 'INCLUDEPATH += /nix/store/dmy9q4cm6c9nzdar7nqgn06gvkgxsid1-icu4c-67.1-dev/include /nix/store/7dw65jc4r4vkaqizzcx1njyryi8vw7vm-zlib-1.2.11-dev/include /nix/store/fhmc6vlgh1vcjilhs4z5fjlfr6qbbqmq-libjpeg-turbo-2.0.5-dev/include /nix/store/yr68z4q8i7bzk6z93q58vvzqwyvyy33i-harfbuzz-2.7.1-dev/include /nix/store/bid8wmf6fb5kg702ywnl7zjzh5158dnr-openssl-1.1.1g-dev/include' /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/config.tests/verifyspec
> /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/toolchain.prf:3: Cannot find feature sdk
> Info: creating stash file /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/config.tests/.qmake.stash
> /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/default_post.prf:5: 'xcodeSDKInfo' is not a recognized replace function.
> Project WARNING: Qt requires at least version 10.14 of the platform SDK, you're building against version . Please upgrade.
+ cd /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/config.tests/verifyspec && MAKEFLAGS= /nix/store/c3v8mz19las3k4afgqfjj9h054yv9sbz-gnumake-4.3/bin/make
> Makefile:69: /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/sdk.mk: No such file or directory
> make: *** No rule to make target '/private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/sdk.mk'.  Stop.
Note: Option 'verbose' with value 'true' was specified twice

Note: -docdir is not a subdirectory of -prefix.
Note: -plugindir is not a subdirectory of -prefix.
Note: -qmldir is not a subdirectory of -prefix.

ERROR: Cannot compile a minimal program. The toolchain or QMakeSpec is broken.
builder for '/nix/store/4v66czqj5sv19i335rpnykkj96ww3zwa-qtbase-5.14.2.drv' failed with exit code 3
cannot build derivation '/nix/store/w7apblbplwv1qf393q9ahljv9l3wy01h-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/v2a97qadijl3qlqb4rkg2m8y0vljr6m3-python3.6-plover-4.0.0.dev8.drv': 1 dependencies couldn't be built
error: build of '/nix/store/v2a97qadijl3qlqb4rkg2m8y0vljr6m3-python3.6-plover-4.0.0.dev8.drv' failed

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102127 run on x86_64-linux 1

1 package built:
  • plover.dev

@braunse braunse mentioned this pull request Oct 30, 2020
Closed
10 tasks
@FRidh
Copy link
Member

FRidh commented Oct 30, 2020 •
edited

@FRidh I'm not sure I completely understood the libsForQt + Python problem, could you double check that this is not a stupid way of fixing the problem? Thanks.

This looks good to me. Both dev and stable function with it.

@FRidh FRidh merged commit ee36b1c into NixOS:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plover.dev: broken in nixos-unstable (master)
3 participants
@delroth @SuperSandro2000 @FRidh