Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

velero: 1.5.1 -> 1.5.2 #102128

Merged
merged 1 commit into from Nov 18, 2020
Merged

velero: 1.5.1 -> 1.5.2 #102128

merged 1 commit into from Nov 18, 2020

Conversation

bryanasdev000
Copy link
Member

@bryanasdev000 bryanasdev000 commented Oct 30, 2020 •
edited

Motivation for this change

Update velero package to take advantage of the resources available in the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bryanasdev000
velero: 1.5.1 -> 1.5.2
2c82b84 
Signed-off-by: Bryan A. S <bryanasdev000@gmail.com>
@ofborg ofborg bot requested a review from kalbasit October 30, 2020 03:38
@dbirks
Copy link
Member

dbirks commented Oct 30, 2020

Result of nixpkgs-review pr 102128 1

1 package built:
  • velero

@bryanasdev000 bryanasdev000 mentioned this pull request Nov 5, 2020
Closed
1 task
@bryanasdev000
Copy link
Member Author

Just to update, that PR is also necessary to avoid this possible security error:
GHSA-72xg-3mcq-52v4 / https://nvd.nist.gov/vuln/detail/CVE-2020-3996

@ryantm ryantm merged commit 6c74dc7 into NixOS:master Nov 18, 2020
@bryanasdev000 bryanasdev000 deleted the package-velero-1.5.2 branch May 3, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbirks dbirks dbirks approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bryanasdev000 @dbirks @ryantm