Skip to content

nixos/systemd-resolved: fix incorrect user #102924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2020
Merged

nixos/systemd-resolved: fix incorrect user #102924

merged 1 commit into from
Nov 5, 2020
+1 −1

Conversation

peterhoeg
Copy link
Member

Motivation for this change

I don't know the reason for assiging the group systemd-resolved to the
systemd-resolved user in the first place, but in any case, what we are
doing now is wrong as it leads to a normal interactive user being
created called resolved instead of actually assiging the group to
systemd-resolved.

Considering this never worked, I'm thinking we can also just drop this
completely but maybe @WillyButz has some details concerning the reason
for the original change?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@peterhoeg
nixos/systemd-resolved: fix incorrect user

Verified

This commit was signed with the committer’s verified signature. The key has expired.
andir Andreas Rammhold
GPG key ID: E432E410B5E48C86
Expired
Verified
Learn about vigilant mode
ff5bbfd
@peterhoeg peterhoeg requested a review from WilliButz November 5, 2020 12:51
@peterhoeg
Copy link
Member Author

I meant @WilliButz , sorry for the typo.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 5, 2020
WilliButz
WilliButz approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I wasn't aware of this issue. I just checked the original PR (#74084), where this was already mentioned before, which I did not notice until now.
The motivation for the change was the usage of nogroup in those services and the need for networkd to access wireguard keys via group permissions.

Thank you for fixing it 👍

@peterhoeg peterhoeg merged commit 13ed0cc into NixOS:master Nov 5, 2020
@peterhoeg peterhoeg deleted the f/resolved branch November 5, 2020 14:42
@Jayman2000 Jayman2000 mentioned this pull request Feb 26, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @WilliButz