Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amdvlk: 2020.Q4.2 -> 2020.Q4.3 #102925

Merged
merged 1 commit into from Nov 5, 2020
Merged

amdvlk: 2020.Q4.2 -> 2020.Q4.3 #102925

merged 1 commit into from Nov 5, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Nov 5, 2020

Motivation for this change

That felt like a short update cycle, here we go with 2020.Q4.3: https://github.com/GPUOpen-Drivers/AMDVLK/releases/tag/v-2020.Q4.3
Tested with vkcube and Dota 2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from danieldk November 5, 2020 13:08
danieldk
danieldk approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick! (Both upstream and your update 😉).

Result of nixpkgs-review pr 102925 1

2 packages built:
  • amdvlk
  • driversi686Linux.amdvlk

Looks good otherwise too.

@danieldk danieldk merged commit 9056d2d into NixOS:master Nov 5, 2020
@Flakebi Flakebi deleted the amdvlk branch November 5, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Flakebi @danieldk