New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tzdata: revert to fat format #102946
tzdata: revert to fat format #102946
Conversation
The timezone dumps have switched to a "slim" format since 2020b. This has broken various packages, including - go 1.4 (used for bootstrapping) - haskellPackages.tz - libical The "fat" format can still be generated, as this commit shows. It seems to create files that are *mostly* the slim versions with some more data attached.
As the |
It was valuable because it helped change my mind, letting me find the root cause and a better solution. That doesn't necessarily mean it will be valuable in the future though. |
We already disable lots of tests for the |
This reverts commit 9c5154b.
b83c095
to
e7bc4ff
Compare
Sure enough. You're the go maintainer, not me :) |
How wide are the breakages? Can we do it on staging-next? |
I don't know how wide. It only shows when you miss an appointment. I don't know which time zones and time ranges are affected. |
Channel blocking. https://hydra.nixos.org/build/129869656 If reverting to the old format while keeping the latest version of tzdata is enough, then let's do that. Wel'll need to undo the disabling of the tests as well then and this needs to target staging-next. |
@GrahamcOfBorg build libical |
@doronbehar is that I don't know the exact details of the format change, but a certain section of data is missing in the "slim" format. It's supposedly redundant, but some programs clearly still depend on it. The wrong |
@roberth that's from the current latest I also noticed that manually setting a certain time or using a different time zone, keeps reverting me back to the old time zone. |
You can use |
I can reproduce this in |
Then maybe we should patch glib with https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1705 ? |
There has been a new glib release since, currently testing diff --git a/pkgs/desktops/gnome-3/core/gnome-control-center/default.nix b/pkgs/desktops/gnome-3/core/gnome-control-center/default.nix
index 1300f7a7503..0695aeb2cb8 100644
--- a/pkgs/desktops/gnome-3/core/gnome-control-center/default.nix
+++ b/pkgs/desktops/gnome-3/core/gnome-control-center/default.nix
@@ -94,6 +94,14 @@ stdenv.mkDerivation rec {
];
buildInputs = [
+ (glib.overrideAttrs (attrs: rec {
+ inherit (attrs) pname;
+ version = "2.66.2";
+ src = fetchurl {
+ url = "mirror://gnome/sources/glib/${stdenv.lib.versions.majorMinor version}/${pname}-${version}.tar.xz";
+ sha256 = "1i0pd8y6xz64qlzfj73wxyqp0x7x9j6mwf4gj6ggil4d9vnhnfgc";
+ };
+ }))
accountsservice
adwaita-icon-theme
cheese
@@ -103,7 +111,6 @@ stdenv.mkDerivation rec {
colord-gtk
fontconfig
gdk-pixbuf
- glib
glib-networking
gnome-bluetooth
gnome-desktop
diff --git a/pkgs/desktops/gnome-3/core/gnome-settings-daemon/default.nix b/pkgs/desktops/gnome-3/core/gnome-settings-daemon/default.nix
index 3c039bc6310..cc21910d3d6 100644
--- a/pkgs/desktops/gnome-3/core/gnome-settings-daemon/default.nix
+++ b/pkgs/desktops/gnome-3/core/gnome-settings-daemon/default.nix
@@ -76,8 +76,15 @@ stdenv.mkDerivation rec {
];
buildInputs = [
+ (glib.overrideAttrs (attrs: rec {
+ inherit (attrs) pname;
+ version = "2.66.2";
+ src = fetchurl {
+ url = "mirror://gnome/sources/glib/${stdenv.lib.versions.majorMinor version}/${pname}-${version}.tar.xz";
+ sha256 = "1i0pd8y6xz64qlzfj73wxyqp0x7x9j6mwf4gj6ggil4d9vnhnfgc";
+ };
+ }))
gtk3
- glib
gsettings-desktop-schemas
modemmanager
networkmanager |
Yes, that seems to fix it. |
{
environment.etc.zoneinfo.source = lib.mkForce "${
pkgs.tzdata.overrideAttrs (old: {
makeFlags = old.makeFlags
++ [ ''CFLAGS+=-DZIC_BLOAT_DEFAULT=\"fat\"'' ];
})
}/share/zoneinfo";
} |
That fixed it for me, Thanks! |
Motivation for this change
The tzdata default format has changed, breaking some packages. We'll want to stick to the old format until the libraries and applications actually support the new format.
cc @zowoq, @jtojnar
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)