Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/networking: make /etc/netgroup by default #102870

Closed
wants to merge 1 commit into from
Closed

nixos/networking: make /etc/netgroup by default #102870

wants to merge 1 commit into from

Conversation

omasanori
Copy link
Contributor

@omasanori omasanori commented Nov 5, 2020 •
edited

Motivation for this change

NixOS now generates an empty file /etc/netgroup by default. It will suppress the "/etc/netgroup: No such file or directory" messages from nscd.
Inspired by #68671 but I changed config/networking.nix instead of services/networking/nscd.nix since the file is not specific to glibc.

Fixes #68603

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@omasanori omasanori changed the title nixos/networking: make /etc/netgroups by default nixos/networking: make /etc/netgroup by default Nov 5, 2020
@omasanori
nixos/networking: make /etc/netgroup by default
a101f2e 
This will prevent nscd from complaining /etc/netgroup being absent.

Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
@omasanori
Copy link
Contributor Author

Rebased to resolve conflicts.

@omasanori omasanori closed this Jan 7, 2021
@omasanori omasanori deleted the nixos/netgroup branch January 7, 2021 19:09
@omasanori omasanori restored the nixos/netgroup branch January 7, 2021 19:09
@bjornfor
Copy link
Contributor

bjornfor commented Jan 7, 2021

Why did you close? I'm not familiar with netgroup or NIS, but I dislike system warning/error messages by default, so would like to see something like this merged.

@omasanori
Copy link
Contributor Author

It is closed by mistake, sorry.

@omasanori omasanori mentioned this pull request Jan 7, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nscd complaining about not finding /etc/netgroup
3 participants
@omasanori @bjornfor @alyssais