Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compcert: remove annoying assertions #102874

Merged
merged 1 commit into from Nov 12, 2020
Merged

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 5, 2020

Motivation for this change

Currently, when trying to override the derivation for CompCert in order to build a different version (e.g., an earlier version that requires Coq 8.8), you are greeted with:

error: assertion (((lib).versionAtLeast (coq).coq-version) "8.8.0") failed

This PR just removes this nonsensical assertion and its neighbor.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl vbgl merged commit ee45591 into NixOS:master Nov 12, 2020
@vbgl vbgl deleted the compcert-easy-to-override branch November 12, 2020 07:20
@vbgl
Copy link
Contributor Author

vbgl commented Nov 12, 2020

Merged into 20.09 as bb20ef2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant