Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] php73: 7.3.23 -> 7.3.24 #102920

Merged
merged 1 commit into from Nov 6, 2020
Merged

[20.09] php73: 7.3.23 -> 7.3.24 #102920

merged 1 commit into from Nov 6, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Nov 5, 2020

Motivation for this change

Backport of #102716

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
php73: 7.3.23 -> 7.3.24
f594a23 
(cherry picked from commit fc48e6f)
@etu etu added the 8.has: port to stable A PR already has a backport to the stable release. label Nov 5, 2020
@ofborg ofborg bot requested review from aanderse, talyz, globin and Ma27 November 5, 2020 12:35
@aanderse
Copy link
Member

aanderse commented Nov 6, 2020

Hmm... 🤔 Someone will have to take a look at errors. If I can find some time tomorrow I'll try.

@etu
Copy link
Contributor Author

etu commented Nov 6, 2020

It seems to fail to unpack source files...

tar: php-7.3.24/Zend: Cannot mkdir: No space left on device

@aanderse
Copy link
Member

aanderse commented Nov 6, 2020

Oh I probably should have looked. That must just be the bot running low on disk space then. So good to merge...?

@Ma27 Ma27 merged commit 17e87d0 into NixOS:release-20.09 Nov 6, 2020
@etu etu deleted the 2009-php73-update branch November 6, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@aanderse aanderse Awaiting requested review from aanderse

@talyz talyz Awaiting requested review from talyz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @aanderse @Ma27