Skip to content

elixir_1_11: 1.11.1 -> 1.11.2 #102931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

elixir_1_11: 1.11.1 -> 1.11.2 #102931

merged 1 commit into from
Nov 9, 2020
+2 −2

Conversation

braunse
Copy link
Contributor

@braunse braunse commented Nov 5, 2020

Motivation for this change

Upstream release: https://github.com/elixir-lang/elixir/releases/tag/v1.11.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Package closure size impact:
/nix/store/s0fy5r3s0j74cadsnr045w3y52hy1p8b-elixir-1.11.2         605687792
/nix/store/b2a9cgvzjj4dbhdwm8krpd64kj441lpw-elixir-1.11.1         615837792

Sorry, something went wrong.

@braunse
elixir_1_11: 1.11.1 -> 1.11.2

Verified

This commit was signed with the committer’s verified signature. The key has expired.
grahamc Graham Christensen
GPG key ID: ACA1C1D120C83D5C
Expired
Verified
Learn about vigilant mode
b482485
@braunse
Copy link
Contributor Author

braunse commented Nov 5, 2020

Result of nixpkgs-review pr 102931 1

1 package built:
  • elixir

@braunse
Copy link
Contributor Author

braunse commented Nov 5, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 5, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 needs_reviewer (old Marvin label, do not use) labels Nov 5, 2020
@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 102931 1

1 package built:
  • elixir (elixir_1_11)

@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed needs_reviewer (old Marvin label, do not use) labels Nov 7, 2020
@thiagokokada
Copy link
Contributor

thiagokokada commented Nov 7, 2020 •
edited
Loading

Tested all binaries, they seem to work.

/status needs_merger

@marvin-mk2 marvin-mk2 bot added needs_merger (old Marvin label, do not use) and removed awaiting_reviewer (old Marvin label, do not use) labels Nov 7, 2020
@marvin-mk2 marvin-mk2 bot requested a review from timokau November 7, 2020 23:30
@marvin-mk2 marvin-mk2 bot added awaiting_merger (old Marvin label, do not use) and removed needs_merger (old Marvin label, do not use) labels Nov 7, 2020
@alyssais alyssais merged commit 6780f45 into NixOS:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada

@timokau timokau

Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 awaiting_merger (old Marvin label, do not use) marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@braunse @thiagokokada @alyssais