Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seaweedfs: init at 2.07 #102939

Closed
wants to merge 1 commit into from
Closed

seaweedfs: init at 2.07 #102939

wants to merge 1 commit into from

Conversation

raboof
Copy link
Member

@raboof raboof commented Nov 5, 2020

Motivation for this change

Submitted on behalf of kvtb who chose not to create a GitHub account yet.

https://discourse.nixos.org/t/casual-nixpkgs-contributions/9607/7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/casual-nixpkgs-contributions/9607/8

@ofborg ofborg bot requested a review from kalbasit November 5, 2020 16:27
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102939 run on x86_64-linux 1

1 package built:
  • seaweedfs

@raboof raboof changed the title seaweed: init at 2.07 seaweedfs: init at 2.07 Nov 6, 2020
@raboof raboof force-pushed the seaweed-init-at-2.07 branch 2 times, most recently from c744526 to b57eb40 Compare November 7, 2020 08:36
@raboof raboof requested a review from danieldk November 7, 2020 08:37
danieldk
danieldk approved these changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the changes. I made a small change to the maintainers attr (since lib was already in scope).

Result of nixpkgs-review pr 102939 1

1 package built:
  • seaweedfs

I'll merge after ofborg is also happy.

@danieldk
Copy link
Contributor

danieldk commented Nov 7, 2020

Weird, GitHub is in an inconsistent state. This PR is merged, but it's still saying open for me.

etu pushed a commit to etu/nixpkgs that referenced this pull request Nov 7, 2020
@danieldk
Merge pull request NixOS#102939 from raboof/seaweed-init-at-2.07
e07a6ca 
seaweedfs: init at 2.07
@danieldk danieldk closed this Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@danieldk danieldk danieldk approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raboof @nixos-discourse @SuperSandro2000 @danieldk