Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GlasgowEmbedded/glasgow
base: 63158ccd8334
Choose a base ref
...
head repository: GlasgowEmbedded/glasgow
compare: 42144aa6a487
Choose a head ref
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on Nov 5, 2020

  1. applet.interface.jtag_probe: reliably detect overlong XR scans.

    @whitequark
    whitequark committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    f09d52c View commit details
    Browse the repository at this point in the history

  2. applet.interface.jtag_probe: move XR scan limits to JTAGProbeInterface. 

    Before this commit, these rarely useful options had to be threaded
through a lot of unrelated code, which polluted interfaces and was
done quite inconsistently.

Also, do not call add_run_arguments() from add_run_tap_arguments().
This was inconsistent with our conventions and required an `access`
argument in add_run_tap_arguments() that was otherwise unnecessary.
    @whitequark
    whitequark committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    d889c3b View commit details
    Browse the repository at this point in the history

  3. applet.interface.jtag_probe: remove scan_dr(zero_ok=) argument. 

    Before this commit, this option used only in enumerate-ir had to be
threaded through a lot of unrelated code, which polluted interfaces
and made the logic hard to understand.

Also, tighten the post-conditions on scan_xr_length() such that it
always requires a valid scan result (finite non-zero length).
    @whitequark
    whitequark committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    42144aa View commit details
    Browse the repository at this point in the history