Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsoncpp: 1.9.2 -> 1.9.4 #102923

Closed
wants to merge 1 commit into from
Closed

jsoncpp: 1.9.2 -> 1.9.4 #102923

wants to merge 1 commit into from

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 5, 2020 •
edited

Motivation for this change

Removing obsolete patches in the process

Adding new features:

  • static flag (disabled by default) to generate a static library instead
  • pkgsStatic override to use it
  • addition of python3 test support
  • removal of the intermediate object files in output
  • split into multiple outputs
  • pkgconfig .pc support files in $dev

Was not able to test the darwin build to check the local preBuild phase there

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from ttuegel and cpages November 5, 2020 12:55
@freezeboy
jsoncpp: 1.9.2 -> 1.9.4
615da1a 
Removing obsolete patches in the process

Adding new features:

* static flag (disabled by default) to generate a static library instead
* pkgsStatic override to use it
* addition of python3 test support
* removal of the intermediate object files in output
* split into multiple outputs for shared variant
* pkgconfig .pc support files in $dev
@r-burns
Copy link
Contributor

r-burns commented Nov 5, 2020

fyi #102379

@freezeboy
Copy link
Contributor Author

Ok closing then

@freezeboy freezeboy closed this Nov 5, 2020
@freezeboy freezeboy deleted the update-jsoncpp branch November 8, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

@cpages cpages Awaiting requested review from cpages

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @r-burns