Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mono6: 6.0.0.313 -> 6.12.0.90 #102919

Merged
merged 1 commit into from Nov 6, 2020
Merged

mono6: 6.0.0.313 -> 6.12.0.90 #102919

merged 1 commit into from Nov 6, 2020

Conversation

poita66
Copy link
Contributor

@poita66 poita66 commented Nov 5, 2020

Motivation for this change

Mono 6 is out-of-date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [✓] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [✓] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

@poita66 thanks for opening your first PR to nixpkgs! :)

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/102919
8 packages marked as broken and skipped:
dotnetPackages.ExtCore gdata-sharp monodevelop python27Packages.pythonnet python37Packages.pythonnet python38Packages.pythonnet scallion ue4

7 packages failed to build:
dotnetPackages.FSharpAutoComplete dotnetPackages.FSharpCompilerService foundationdb60 fsharp41 python27Packages.foundationdb60 python37Packages.foundationdb60 python38Packages.foundationdb60

148 packages built:
appindicator-sharp avrdudess bless boogie btcpayserver ckan convchain dafny dbus-sharp-1_0 dbus-sharp-2_0 dbus-sharp-glib-1_0 dbus-sharp-glib-2_0 dotnetPackages.Autofac dotnetPackages.Deedle dotnetPackages.ExcelDna dotnetPackages.ExcelDnaRegistration dotnetPackages.FSharpCompilerCodeDom dotnetPackages.FSharpCompilerTools dotnetPackages.FSharpCore302 dotnetPackages.FSharpCore3125 dotnetPackages.FSharpCore4001 dotnetPackages.FSharpCore4117 dotnetPackages.FSharpData dotnetPackages.FSharpData225 dotnetPackages.FSharpDataSQLProvider dotnetPackages.FSharpFormatting dotnetPackages.Fake dotnetPackages.Fantomas dotnetPackages.FsCheck dotnetPackages.FsCheck262 dotnetPackages.FsCheckNunit dotnetPackages.FsLexYacc dotnetPackages.FsLexYacc706 dotnetPackages.FsLexYaccRuntime dotnetPackages.FsPickler dotnetPackages.FsUnit dotnetPackages.FuzzyLogicLibrary dotnetPackages.GitVersionTree dotnetPackages.MathNetNumerics dotnetPackages.MaxMindDb dotnetPackages.MaxMindGeoIP2 dotnetPackages.MicrosoftDiaSymReader dotnetPackages.MicrosoftDiaSymReaderPortablePdb dotnetPackages.MonoAddins dotnetPackages.MonoNat dotnetPackages.NDeskOptions dotnetPackages.NUnit dotnetPackages.NUnit3 dotnetPackages.NUnit350 dotnetPackages.NUnitConsole dotnetPackages.NUnitRunners dotnetPackages.NewtonsoftJson dotnetPackages.Nuget dotnetPackages.OpenNAT dotnetPackages.Paket dotnetPackages.Projekt dotnetPackages.RestSharp dotnetPackages.SharpFont dotnetPackages.SharpZipLib dotnetPackages.SmartIrc4net dotnetPackages.StyleCopMSBuild dotnetPackages.StyleCopPlusMSBuild dotnetPackages.Suave dotnetPackages.SystemCollectionsImmutable dotnetPackages.SystemCollectionsImmutable131 dotnetPackages.SystemReflectionMetadata dotnetPackages.SystemValueTuple dotnetPackages.UnionArgParser dotnetbuildhelpers duplicati eventstore foundationdb foundationdb51 foundationdb52 fsharp gio-sharp gnome-sharp gtk-sharp-2_0 gtk-sharp-3_0 gtk-sharp-beans haskellPackages.clr-bindings haskellPackages.clr-host haxePackages.hxcs hyena jackett keepass keepass-keeagent keepass-keepasshttp keepass-keepassrpc keepass-otpkeyprov kodiPlugins.steam-launcher lidarr lutris midisheetmusic mono mono-addins mono4 mono6 msbuild nbxplorer notify-sharp omnisharp-roslyn openra openraPackages.engines.bleed openraPackages.engines.playtest openraPackages.mods.ca openraPackages.mods.d2 openraPackages.mods.dr openraPackages.mods.gen openraPackages.mods.kknd openraPackages.mods.mw openraPackages.mods.ra2 openraPackages.mods.raclassic openraPackages.mods.rv openraPackages.mods.sp openraPackages.mods.ss openraPackages.mods.ura openraPackages.mods.yr osu-lazer pash pdfmod pinta python-language-server python27Packages.foundationdb51 python27Packages.foundationdb52 python27Packages.foundationdb61 python37Packages.foundationdb51 python37Packages.foundationdb52 python37Packages.foundationdb61 python38Packages.foundationdb51 python38Packages.foundationdb52 python38Packages.foundationdb61 radarr ryujinx sonarr sparkleshare steam steam-run steam-run-native steamcmd supertux-editor syntex taglib-sharp tomboy vscode-extensions.ms-vscode.cpptools wasabibackend wavefunctioncollapse webkit2-sharp

@jonringer jonringer marked this pull request as ready for review November 6, 2020 22:39
@jonringer jonringer merged commit ade59d2 into NixOS:master Nov 6, 2020
@poita66
Copy link
Contributor Author

poita66 commented Nov 9, 2020

Thanks @jonringer! I was worried that I also needed to sort out the packages that failed to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants