Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scala: Add tests, update script #102928

Merged
merged 2 commits into from Nov 5, 2020
Merged

scala: Add tests, update script #102928

merged 2 commits into from Nov 5, 2020

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Add tests, update script

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NeQuissimus
scala: Refactor, add tests
6834d33 
Abstract over Scala derivation, add tests for individual versions
@NeQuissimus NeQuissimus added the 6.topic: updaters Tooling for (semi-)automated updating of packages label Nov 5, 2020
@ofborg ofborg bot added the 6.topic: nixos label Nov 5, 2020
@NeQuissimus NeQuissimus merged commit 55dbb2f into NixOS:master Nov 5, 2020
@NeQuissimus NeQuissimus deleted the scala_test branch November 5, 2020 15:26
@cocreature
Copy link
Contributor

Hi @NeQuissimus, before this change we were able to call scala_2_12.override { jre = … }. However, this no longer works since scala_2_12 no longer has an override attribute. What’s the recommended way of handling this?

@NeQuissimus
Copy link
Member Author

I fixed that in 7f50f98

@cocreature
Copy link
Contributor

Awesome, thank you very much for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 6.topic: updaters Tooling for (semi-)automated updating of packages 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NeQuissimus @cocreature