Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencv: 2.4.13 -> 2.4.13.7 #102918

Merged
merged 2 commits into from Nov 11, 2020
Merged

opencv: 2.4.13 -> 2.4.13.7 #102918

merged 2 commits into from Nov 11, 2020

Conversation

omasanori
Copy link
Contributor

Motivation for this change

This change updates OpenCV 2 to the latest version in 2.4 series hosted at opencv/opencv.
opencv2, p2pvc and pfstools are built without errors but they are not really tested.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@omasanori
opencv: 2.4.13 -> 2.4.13.7
f1d3f6b 
It updates the repository URL to opencv/opencv. opencv2, p2pvc and
pfstools are built without errors but not really tested.

Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102918 run on x86_64-linux 1

7 packages marked as broken and skipped:
  • mathematica
  • mathematica10
  • mathematica11
  • mathematica9
  • opencv2
  • p2pvc
  • pfstools

@alyssais
Copy link
Member

alyssais commented Nov 9, 2020

Should this be removed?

nixpkgs/pkgs/development/libraries/opencv/default.nix

Line 90 in f1d3f6b

broken = true;

@omasanori
Copy link
Contributor Author

@alyssais Ah, yes, if broken means fails to build then this commit unbreak it. I will revise the PR. Thank you for the suggestion.

@omasanori
opencv: unbreak 2.4.13.7
ce438bd 
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
@LEXUGE
Copy link
Contributor

LEXUGE commented Nov 11, 2020

LGTM

@LEXUGE LEXUGE requested a review from Ma27 November 11, 2020 07:44
@Ma27 Ma27 merged commit 13b5c8a into NixOS:master Nov 11, 2020
@omasanori omasanori deleted the opencv/update-2.4.13.7 branch November 19, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@omasanori @SuperSandro2000 @alyssais @LEXUGE @Ma27