pugixml: 1.9 -> 1.10 #102926
Merged
pugixml: 1.9 -> 1.10 #102926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* split to multiple outputs when using the shared library version * enabled the tests * validate the pkg-config files
jonringer
approved these changes
Nov 6, 2020
There was a problem hiding this comment.
LGTM
failures are broken on target branch
https://github.com/NixOS/nixpkgs/pull/102926
1 package marked as broken and skipped:
photoflow
1 package failed to build:
appleseed
13 packages built:
PlistCpp darktable filezilla gerbera gnss-sdr kodi-wayland kodiPlainWayland mudlet osl poedit pugixml waylandpp xib2nib
Comment on lines
+28
to
+30
| export DYLD_LIBRARY_PATH="`pwd`''${DYLD_LIBRARY_PATH:+:}$DYLD_LIBRARY_PATH" | ||
| '' else '' | ||
| export LD_LIBRARY_PATH="`pwd`''${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH" |
There was a problem hiding this comment.
Suggested change
| export DYLD_LIBRARY_PATH="`pwd`''${DYLD_LIBRARY_PATH:+:}$DYLD_LIBRARY_PATH" | |
| '' else '' | |
| export LD_LIBRARY_PATH="`pwd`''${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH" | |
| export DYLD_LIBRARY_PATH="$(pwd)''${DYLD_LIBRARY_PATH:+:}$DYLD_LIBRARY_PATH" | |
| '' else '' | |
| export LD_LIBRARY_PATH="$(pwd)''${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH" |
|
I have a doubt, do i open another pr with the suggestion? |
|
go for it |
jonringer
reviewed
Nov 6, 2020
| cmakeFlags = [ "-DBUILD_SHARED_LIBS=${if shared then "ON" else "OFF"}" ]; | ||
| # Hack to be able to run the test, broken because we use | ||
| # CMAKE_SKIP_BUILD_RPATH to avoid cmake resetting rpath on install | ||
| preBuild = if stdenv.isDarwin then '' |
There was a problem hiding this comment.
if this is specific for tests, please do preCheck to avoid this affecting the build or install
|
Result of 1 package marked as broken and skipped:
5 packages built:
|
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)