Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdr-plus: init at 2020-10-29 #102922

Merged
merged 1 commit into from Jan 18, 2021
Merged

hdr-plus: init at 2020-10-29 #102922

merged 1 commit into from Jan 18, 2021

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Nov 5, 2020

Motivation for this change

hdr-plus is a burst photography pipeline implementation based on Google's HDR+ pipeline. More details can be found here. I'm packaging this for the Megapixels app (#98479) which greatly benefits from using the stack_frames binary provided by this project.

The included patch is required for building against Halide 10.0.0, it's a squashed version of my upstream PR timothybrooks/hdr-plus#70.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

IvarWithoutBones
IvarWithoutBones requested changes Nov 18, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor nits 👍

pkgs/applications/graphics/hdr-plus/0001-Update-to-Halide-10.0.0.patch Outdated Show resolved Hide resolved
pkgs/applications/graphics/hdr-plus/default.nix Outdated Show resolved Hide resolved
@OPNA2608 OPNA2608 changed the title hdr-plus: init at unstable-2020-10-29 hdr-plus-unstable: init at 2020-10-29 Nov 19, 2020
SuperSandro2000
SuperSandro2000 requested changes Nov 27, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fetch the upstream patch instead of putting it into nix?

pkgs/applications/graphics/hdr-plus/default.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102922 run on x86_64-linux 1

1 package built:
  • hdr-plus

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102922 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • hdr-plus

@OPNA2608
Copy link
Contributor Author

I figured it'd be more stable to include the patch here instead of referring to my PR commit (that I may-or-may-not force-push over again at some point) but sure, will do.

@OPNA2608 OPNA2608 changed the title hdr-plus-unstable: init at 2020-10-29 hdr-plus: init at 2020-10-29 Dec 29, 2020
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 102922 run on x86_64-linux 1

1 package built:
  • hdr-plus

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102922 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • hdr-plus

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 102922 run on x86_64-linux 1

1 package built:
  • hdr-plus

@SuperSandro2000 SuperSandro2000 merged commit d59593d into NixOS:master Jan 18, 2021
@OPNA2608 OPNA2608 deleted the init/hdr-plus/21.03 branch September 27, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@IvarWithoutBones IvarWithoutBones IvarWithoutBones requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OPNA2608 @SuperSandro2000 @IvarWithoutBones