open-sans: fix revision: remove URL encoding #101586
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fetching
open-sans
by removing unwanted URL encoding ofrev
.Motivation for this change
Currently
fetchFromGitLab
call inopen-sans
package fails. ApparentlyfetchFromGitLab
doesn't needrev
to be pre-URL-encoded anymore. I don't know if it ever did. With currentmaster
, buildingopen-sans
results in the following error (note revision in the final URL is double-encoded):Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)