Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open-sans: fix revision: remove URL encoding #101586

Merged
merged 1 commit into from Oct 24, 2020

Conversation

quyse
Copy link
Contributor

@quyse quyse commented Oct 24, 2020

Fix fetching open-sans by removing unwanted URL encoding of rev.

Motivation for this change

Currently fetchFromGitLab call in open-sans package fails. Apparently fetchFromGitLab doesn't need rev to be pre-URL-encoded anymore. I don't know if it ever did. With current master, building open-sans results in the following error (note revision in the final URL is double-encoded):

# nix-build -A open-sans --no-link --check
checking outputs of '/nix/store/4d4jcvhgwp896g71anr9jb3kwlin1zj7-open-sans-1.11.drv'...

trying https://salsa.debian.org/api/v4/projects/fonts-team%2Ffonts-open-sans/repository/archive.tar.gz?sha=debian%252F1.11-1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
error: cannot download open-sans-1.11 from any mirror
builder for '/nix/store/4d4jcvhgwp896g71anr9jb3kwlin1zj7-open-sans-1.11.drv' failed with exit code 1
error: build of '/nix/store/4d4jcvhgwp896g71anr9jb3kwlin1zj7-open-sans-1.11.drv' failed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Remove URL encoding of revision, it results in double encoding.
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this also needs backports to stable channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants