Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpuid: 20200427 -> 20201006 #101562

Merged
merged 1 commit into from Oct 24, 2020
Merged

cpuid: 20200427 -> 20201006 #101562

merged 1 commit into from Oct 24, 2020

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/cpuid/versions.

meta.description for cpuid is: "Linux tool to dump x86 CPUID information about the CPU"

meta.homepage for cpuid is: "http://etallen.com/cpuid.html"

meta.changelog for cpuid is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand) 
2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
cpuid
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/03i89q76p99h8wp5wbas4a299csmk3vv-cpuid-20201006 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A cpuid https://github.com/r-ryantm/nixpkgs/archive/b4fd542f7f8cf8ffdd3ee5141efe632c58d459c9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/03i89q76p99h8wp5wbas4a299csmk3vv-cpuid-20201006
ls -la /nix/store/03i89q76p99h8wp5wbas4a299csmk3vv-cpuid-20201006/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package built:
  • cpuid
Maintainer pings

cc @blitz for testing.

SuperSandro2000
SuperSandro2000 requested changes Oct 24, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package should be marked linux only.

@ofborg ofborg bot requested a review from blitz October 24, 2020 15:38
blitz
blitz approved these changes Oct 24, 2020
View reviewed changes
Copy link
Contributor

@blitz blitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as intended.

@blitz
Copy link
Contributor

blitz commented Oct 24, 2020

@SuperSandro2000

This package should be marked linux only.

It lives in os-specific/linux and has platforms = [ "i686-linux" "x86_64-linux" ];. What else do you suggest?

@blitz blitz requested a review from tfc October 24, 2020 16:06
@SuperSandro2000
Copy link
Member

@SuperSandro2000

This package should be marked linux only.

It lives in os-specific/linux and has platforms = [ "i686-linux" "x86_64-linux" ];. What else do you suggest?

Nvm. I had allowUnsupportedSystem = true; on for a quick test and forgot to remove it again. 😂 🤦

@blitz
Copy link
Contributor

blitz commented Oct 24, 2020

No worries. ;)

@ryantm ryantm merged commit 5134491 into NixOS:master Oct 24, 2020
@r-ryantm r-ryantm deleted the auto-update/cpuid branch October 24, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@blitz blitz blitz approved these changes

@tfc tfc Awaiting requested review from tfc

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r-ryantm @blitz @SuperSandro2000 @ryantm