Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] nixosTests.ferm: fix network timeout #101574

Merged
merged 1 commit into from Oct 24, 2020
Merged

[20.09] nixosTests.ferm: fix network timeout #101574

merged 1 commit into from Oct 24, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Oct 24, 2020

Motivation for this change

backport of #101258

ZHF: #97479

cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@B4dM4n
nixosTests.ferm: fix network timeout
609c2b6 
The subtests could start before the server has configured it's IP
addresses and therefore timeout.

(cherry picked from commit 2539542)
@jonringer
Copy link
Contributor

@GrahamcOfBorg test ferm

@jonringer jonringer merged commit f928b39 into NixOS:release-20.09 Oct 24, 2020
@B4dM4n B4dM4n deleted the backport-ferm-test-fix branch October 24, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4dM4n @jonringer