Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] nixos/tools: add desktopConfiguration option (to seed configuration into configuration.nix) #101565

Merged
merged 5 commits into from Oct 24, 2020
Merged

[20.09] nixos/tools: add desktopConfiguration option (to seed configuration into configuration.nix) #101565

merged 5 commits into from Oct 24, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Backports #100199

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
nixos/tools: don't mention pinentryFlavor
ce1f2a6 
We don't need to actually set this as it find a good
default automatically. This could confuse the user into thinking they need
to set it themselves.

(cherry picked from commit 12825bc)
@worldofpeace
nixos/tools: comment about libinput
0ae904d 
(cherry picked from commit 9f1a43c)
@worldofpeace
nixos/tools: don't call Plasma KDE
46cecda 
(cherry picked from commit 3b20eb4)
@worldofpeace
nixos/tools: add firefox to systemPackages example
3e594ad 
This is in the graphical iso's.

(cherry picked from commit 2d6a694)
@worldofpeace
nixos/tools: add desktopConfiguration option
0d21510 
We now have a GNOME ISO so it would be nice to seed that one
with configuration on how to enable it.

(cherry picked from commit 99d5111)
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: qt/kde 8.has: module (update) labels Oct 24, 2020
@worldofpeace worldofpeace merged commit 0d21510 into NixOS:release-20.09 Oct 24, 2020
@worldofpeace worldofpeace deleted the backport-100199 branch October 24, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: qt/kde 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace