Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/lightdm: make lightdm user shell bash #101563

Merged
merged 1 commit into from Oct 24, 2020
Merged

nixos/lightdm: make lightdm user shell bash #101563

merged 1 commit into from Oct 24, 2020

Conversation

worldofpeace
Copy link
Contributor

In #100119 pantheon's greeter
has g-s-d running which allows brightness controls via pkexec.
This is changed in newer versions of g-s-d (pantheon uses a fork currently),
but whenever brightness is changed with a shell of shadow we get

Oct 10 23:51:44 kirXps pkexec[18722]: lightdm: Executing command [USER=root] [TTY=unknown] [CWD=/var/lib/lightdm] [COMMAND=/run/current-system/sw/bin/elementary-settings-daemon/gsd-backlight-helper /sys/devices/pci0000:00/0000:00:02.0/drm/card0/card0-eDP-1/intel_backlight 65587]

I'm not sure this should be strictly needed, so we should try to
revert later on when pantheon's g-s-d is updated.

Motivation for this change

Fix #100119

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
nixos/lightdm: make lightdm user shell bash
c134f64 
In NixOS#100119 pantheon's greeter
has g-s-d running which allows brightness controls via pkexec.
This is changed in newer versions of g-s-d (pantheon uses a fork currently),
but whenever brightness is changed with a shell of `shadow` we get
```
Oct 10 23:51:44 kirXps pkexec[18722]: lightdm: Executing command [USER=root] [TTY=unknown] [CWD=/var/lib/lightdm] [COMMAND=/run/current-system/sw/bin/elementary-settings-daemon/gsd-backlight-helper /sys/devices/pci0000:00/0000:00:02.0/drm/card0/card0-eDP-1/intel_backlight 65587]
```

I'm not sure this should be strictly needed, so we should try to
revert later on when pantheon's g-s-d is updated.
@worldofpeace worldofpeace added this to In progress in Pantheon via automation Oct 24, 2020
@worldofpeace worldofpeace merged commit 6bc94d1 into NixOS:master Oct 24, 2020
Pantheon automation moved this from In progress to Done Oct 24, 2020
@worldofpeace worldofpeace deleted the fix-pantheon-greeter-brightness branch October 24, 2020 15:56
@worldofpeace
Copy link
Contributor Author

backported to 20.09 in 89d75bc

@worldofpeace worldofpeace mentioned this pull request Oct 24, 2020
Closed
@bobby285271 bobby285271 mentioned this pull request Aug 19, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Pantheon
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjusting screen brightness in the elementary greeter does not work
1 participant
@worldofpeace