Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pantheon.switchboard-plug-about: patch some bugfixes #101567

Merged
merged 1 commit into from Oct 24, 2020
Merged

pantheon.switchboard-plug-about: patch some bugfixes #101567

merged 1 commit into from Oct 24, 2020

Conversation

worldofpeace
Copy link
Contributor

Hopefully fix #101221.
Though that issue is flaky on the reproducibility.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
pantheon.switchboard-plug-about: patch some bugfixes
372e3a1 
Hopefully fix NixOS#101221.
Though that issue is flaky on the reproducibility.
@worldofpeace worldofpeace merged commit e3e42da into NixOS:master Oct 24, 2020
@worldofpeace worldofpeace deleted the fix-switchboard-about branch October 24, 2020 16:18
@worldofpeace
Copy link
Contributor Author

backported to 20.09 in b387760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: pantheon The Pantheon desktop environment 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pantheon: Settings - About: NixOS logo missing
2 participants
@worldofpeace @nixos-discourse