Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/powerdns: use upstream systemd unit #100063

Merged
merged 4 commits into from Oct 24, 2020
Merged

nixos/powerdns: use upstream systemd unit #100063

merged 4 commits into from Oct 24, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Oct 9, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse force-pushed the nixos/powerdns branch 3 times, most recently from a4baa57 to 826c8e1 Compare October 15, 2020 00:41
@ofborg ofborg bot requested review from disassembler and Mic92 October 15, 2020 00:51
@aanderse aanderse marked this pull request as ready for review October 15, 2020 12:37
@aanderse aanderse requested a review from rnhmjoj October 15, 2020 12:37
@aanderse
Copy link
Member Author

I ran some minimal testing with the gmysql backend using this configuration:

  services.mysql.enable = true;
  services.mysql.package = pkgs.mariadb;
  services.mysql.ensureDatabases = [ "powerdns" ];
  services.mysql.ensureUsers = [
    { name = "pdns";
      ensurePermissions = { "powerdns.*" = "ALL PRIVILEGES"; };
    }
  ];

  services.powerdns.enable = true;
  services.powerdns.extraConfig = ''
    launch=gmysql
    gmysql-user=pdns
    gmysql-host=localhost
  '';

From there I was able to create and edit a zone using pdnsutil (more specifically, sudo -u pdns EDITOR=nano pdnsutil...).

@Mic92
Copy link
Member

Mic92 commented Oct 20, 2020

@GrahamcOfBorg test powerdns

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Oct 20, 2020

I have extended the test with your setup and also added a subtest for changing records with pdnsutil.

rnhmjoj
rnhmjoj approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • package builds
  • manual builds
  • NixOS test passes

Looks good to me.

aanderse and others added 4 commits October 24, 2020 16:40
@aanderse
powerdns: 4.2.3 -> 4.3.1
603f0dc
@aanderse
nixos/powerdns: use upstream systemd unit
4f5d379
@aanderse
nixos/powerdns: update release notes
6393835
@rnhmjoj @aanderse
nixosTests.powerdns: test a complete setup
d5d6f61 
The test now check the following things:
- Configuring a MySQL server to hold the records
- Loading the PowerDNS schema from file
- Adding records through pdnsutil
@aanderse aanderse merged commit a160fa0 into NixOS:master Oct 24, 2020
@aanderse aanderse deleted the nixos/powerdns branch October 24, 2020 22:47
@aanderse aanderse mentioned this pull request Nov 12, 2020
Open
@aanderse aanderse mentioned this pull request Jan 3, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@disassembler disassembler Awaiting requested review from disassembler

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @Mic92 @rnhmjoj