Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signumone-ks: init at 3.1.2 #101607

Closed
wants to merge 1 commit into from
Closed

signumone-ks: init at 3.1.2 #101607

wants to merge 1 commit into from

Conversation

WolfangAukang
Copy link
Contributor

Motivation for this change

This software is required for all workers in Costa Rica for reporting taxes and marking vouchers with Digital Sign (Factura Digital).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

andir
andir requested changes Oct 25, 2020
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. This doesn't look too bad overall.

But I can't see how the resulting binary is supposed to work on a NixOS system.

$ ldd /nix/store/7lirmmw1ii79h8k4gb881j36pyqq2qp7-signumone-ks-3.1.2/bin/SignumOne-KS
	linux-vdso.so.1 (0x00007ffe9b4eb000)
	libdl.so.2 => /nix/store/bdf8iipzya03h2amgfncqpclf6bmy3a1-glibc-2.32/lib/libdl.so.2 (0x00007f3356c03000)
	libstdc++.so.6 => not found
	libm.so.6 => /nix/store/bdf8iipzya03h2amgfncqpclf6bmy3a1-glibc-2.32/lib/libm.so.6 (0x00007f3356ac0000)
	libgcc_s.so.1 => /nix/store/bdf8iipzya03h2amgfncqpclf6bmy3a1-glibc-2.32/lib/libgcc_s.so.1 (0x00007f3356aa6000)
	libc.so.6 => /nix/store/bdf8iipzya03h2amgfncqpclf6bmy3a1-glibc-2.32/lib/libc.so.6 (0x00007f33568e5000)
	/lib64/ld-linux-x86-64.so.2 => /nix/store/bdf8iipzya03h2amgfncqpclf6bmy3a1-glibc-2.32/lib64/ld-linux-x86-64.so.2 (0x00007f3356c0a000)

You likely want to apply patchelf via something like the autoPatchelfHook. This will take all the buildInputs and replace references to them in the output binary so they are properly pointing into the nix store.

Feel free to ping me if you need further information.

@WolfangAukang
Copy link
Contributor Author

Hey @andir, I have performed the updates as requested. It's my first time creating a new package for Nixpkgs, so I had to guide myself with other packages to make this work.

Please let me know if something needs to be done.

andir
andir requested changes Oct 25, 2020
View reviewed changes
pkgs/applications/misc/signumone-ks/default.nix

installPhase = ''
DESKTOP_PATH=$out/share/applications/signumone-ks.desktop
LIB_DIR=$out/lib/signumone-ks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not have to deal with this. Try just putting ffmpeg_2 into buildInputs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I don't add ffmpeg nor ffmpeg_3, I get missing libraries on the build process:

these derivations will be built:
  /nix/store/56pva1pz92dpgqbifgp1h54740dymkcd-signumone-ks-3.1.2.drv
building '/nix/store/56pva1pz92dpgqbifgp1h54740dymkcd-signumone-ks-3.1.2.drv'...
unpacking sources
patching sources
configuring
no configure script, doing nothing
building
no Makefile, doing nothing
glibPreInstallPhase
installing
glibPreFixupPhase
dropIconThemeCache
dropIconThemeCache
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/SignumOne-KS
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libfxplugins.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-56.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libsunec.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-57.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libinstrument.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libglass.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libglib-lite.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjsdt.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/liblcms.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/server/libjvm.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/server/libjsig.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libawt_headless.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libprism_common.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjavafx_font_pango.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libnio.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libj2pkcs11.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjfr.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-56.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libsctp.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libdecora_sse.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-54.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libawt_xawt.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjavafx_iio.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libmanagement.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-58.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libresource.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjdwp.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libgstreamer-lite.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjfxmedia.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libhprof.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libprism_sw.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjsound.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/jli/libjli.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libnpt.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjpeg.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libsplashscreen.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libglassgtk3.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjaas_unix.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjfxwebkit.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libglassgtk2.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libattach.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjavafx_font_freetype.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjava_crw_demo.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libdt_socket.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjsoundalsa.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libnet.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libawt.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libj2pcsc.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjava.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libj2gss.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-57.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libt2k.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libsaproc.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libverify.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libprism_es2.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjavafx_font.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libfontmanager.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjsig.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libunpack.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libdcpr.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-55.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libdeploy.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-53.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libbci.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libjawt.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libzip.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libmlib_image.so
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/jexec
shrinking /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/libpackager.so
strip is /nix/store/hiwz81i1g3fn3p0acjs042a4h5fri6dh-binutils-2.31.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/lib  /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/bin 
patching script interpreter paths in /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2
checking for references to /build/ in /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2...
automatically fixing dependencies for ELF files
searching for dependencies of /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/SignumOne-KS
  libstdc++.so.6 -> found: /nix/store/fym51l26jrpzhlvaj607wd3im9511j2q-gcc-9.3.0-lib/lib/libstdc++.so.6
setting RPATH to: /nix/store/fym51l26jrpzhlvaj607wd3im9511j2q-gcc-9.3.0-lib/lib
searching for dependencies of /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libfxplugins.so
  libgstreamer-lite.so -> found: /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libgstreamer-lite.so
  libglib-lite.so -> found: /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libglib-lite.so
setting RPATH to: /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64:/nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64
searching for dependencies of /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-56.so
  libgstreamer-lite.so -> found: /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libgstreamer-lite.so
  libglib-lite.so -> found: /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libglib-lite.so
  libavcodec-ffmpeg.so.56 -> found: /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/lib/signumone-ks/libavcodec-ffmpeg.so.56
  libavformat-ffmpeg.so.56 -> found: /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/lib/signumone-ks/libavformat-ffmpeg.so.56
setting RPATH to: /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64:/nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64:/nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/lib/signumone-ks:/nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/lib/signumone-ks
searching for dependencies of /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libsunec.so
searching for dependencies of /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-57.so
  libgstreamer-lite.so -> found: /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libgstreamer-lite.so
  libglib-lite.so -> found: /nix/store/10wkm930nii0680yw3ch3dyvxh8i2vkk-signumone-ks-3.1.2/opt/SignumOne-KS/runtime/lib/amd64/libglib-lite.so
  libavcodec.so.57 -> not found!
  libavformat.so.57 -> not found!
builder for '/nix/store/56pva1pz92dpgqbifgp1h54740dymkcd-signumone-ks-3.1.2.drv' failed with exit code 1
error: build of '/nix/store/56pva1pz92dpgqbifgp1h54740dymkcd-signumone-ks-3.1.2.drv' failed

@WolfangAukang
Copy link
Contributor Author

@andir are there any changes required for this package? Please let me know what else is needed to change, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WolfangAukang @andir